[python] Use C++ DataFrame bindings for create and writes
#2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenv
changed the title
DataFrame bindings for create and writes
nguyenv
force-pushed
the
viviannguyen/dataframe-write-path
branch
from
b701cad to
bcae831
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
==========================================
- Coverage 90.14% 89.87% -0.27%
==========================================
Files 37 37
Lines 3956 3941 -15
==========================================
- Hits 3566 3542 -24
- Misses 390 399 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
force-pushed
the
viviannguyen/dataframe-write-path
branch
3 times, most recently
from
445b86a to
999077d
Compare
nguyenv
requested review from
ihnorton,
ryan-williams,
johnkerl,
thetorpedodog and
jp-dark
johnkerl
approved these changes
Apr 16, 2024
|
This once again whitespace changed nanoarrow.h which, as an external file, is not really needed -- and makes comparison to upstream more difficult. |
nguyenv
force-pushed
the
viviannguyen/dataframe-write-path
branch
from
0248889 to
e8ec852
Compare
nguyenv
force-pushed
the
viviannguyen/add-writes-cpp
branch
from
910a586 to
e98bd12
Compare
nguyenv
force-pushed
the
viviannguyen/dataframe-write-path
branch
from
e8ec852 to
4ad9773
Compare
jp-dark
reviewed
Apr 18, 2024
ryan-williams
approved these changes
Apr 20, 2024
nguyenv
force-pushed
the
viviannguyen/dataframe-write-path
branch
from
84ea19d to
9d061e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #2427
Part of larger branch #2367
Changes:
Remove TileDB-Py usage for
DataFrameby usingcreateandwriteC++ bindings.