Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Code-review-feedback follow-up from #2434 #2441

Merged
merged 1 commit into from
Apr 12, 2024
+2 −2
Merged

[python] Code-review-feedback follow-up from #2434 #2441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/python/src/tiledbsoma/io/ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,7 @@
if ingestion_params.error_if_already_exists:
raise SOMAError(f"{soma_df.uri} already exists")

soma_df = _factory.open(df_uri, "w", soma_type=DataFrame, context=context)
soma_df = DataFrame.open(df_uri, "w", context=context)

if ingestion_params.skip_existing_nonempty_domain:
storage_ned = _read_nonempty_domain(soma_df)
Expand Down Expand Up @@ -2757,7 +2757,7 @@
context=context,
)
except AlreadyExistsError:
soma_arr = _factory.open(arr_uri, "w", soma_type=DenseNDArray, context=context)
soma_arr = DenseNDArray.open(arr_uri, "w", context=context)

Check warning on line 2760 in apis/python/src/tiledbsoma/io/ingest.py

View check run for this annotation

Codecov / codecov/patch

apis/python/src/tiledbsoma/io/ingest.py#L2760 

Added line #L2760 was not covered by tests

# If resume mode: don't re-write existing data. This is the user's explicit request
# that we not re-write things that have already been written.
Expand Down
Loading