Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python]Robust URI handling for Ingestion-performance improvement #2457

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Apr 19, 2024

Issue and/or context: [sc-45626]

Changes: Be respectful of creation-URI semantics for multiple object stores. Error introduced on #2434.

Notes for Reviewer: Tested manually using object stores not applicable to this open-source repo -- hence, this repo is not the correct location for unit-test cases of this form

@johnkerl johnkerl changed the title [python] Ingestion performance plus robust URI handling [python]Robust URI handling for Ingestion-performance improvement Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #2457 (dc0142b) into main (4487347) will decrease coverage by 0.29%.
The diff coverage is 36.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
- Coverage   90.43%   90.14%   -0.29%     
==========================================
  Files          37       37              
  Lines        3940     3956      +16     
==========================================
+ Hits         3563     3566       +3     
- Misses        377      390      +13     
Flag Coverage Δ
python 90.14% <36.36%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.14% <36.36%> (-0.29%) ⬇️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@ryan-williams ryan-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but wasn't able to quickly understand where the error messages come from…

apis/python/src/tiledbsoma/_exception.py Show resolved Hide resolved
@johnkerl johnkerl merged commit c538f21 into main Apr 19, 2024
28 checks passed
@johnkerl johnkerl deleted the kerl/creation-update-handling branch April 19, 2024 18:58
johnkerl added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants