Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix unbound-local error #2516

Merged
merged 1 commit into from
May 7, 2024
Merged

[python] Fix unbound-local error #2516

merged 1 commit into from
May 7, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented May 7, 2024

Issue and/or context: Fixes #2499

Changes:

Notes for Reviewer: The customer callpath wasn't provided in its entirety but it's clear where the bug is

@johnkerl johnkerl marked this pull request as ready for review May 7, 2024 15:14
@aaronwolen
Copy link
Member

[sc-46790]

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.25%. Comparing base (676c834) to head (eed5616).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2516   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files          37       37           
  Lines        3950     3950           
=======================================
  Hits         3565     3565           
  Misses        385      385           
Flag Coverage Δ
python 90.25% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.25% <0.00%> (ø)
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 14fea60 into main May 7, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/unbound-local branch May 7, 2024 15:35
Copy link
Member

@ryan-williams ryan-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though same problem appears to exist at L1306:

except (AlreadyExistsError, NotCreateableError):
if ingestion_params.error_if_already_exists:
raise SOMAError(f"{soma_ndarray.uri} already exists")
soma_ndarray = cls.open(
uri, "w", platform_config=platform_config, context=context
)

(here on #2434)

johnkerl added a commit that referenced this pull request May 7, 2024
@johnkerl johnkerl mentioned this pull request May 7, 2024
@johnkerl
Copy link
Member Author

johnkerl commented May 7, 2024

lgtm, though same problem appears to exist at L1306:

Thanks @ryan-williams ! #2522

johnkerl added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] UnboundLocalError: local variable soma_df referenced before assignment
3 participants