-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Fix unbound-local error #2516
Conversation
[sc-46790] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2516 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 37 37
Lines 3950 3950
=======================================
Hits 3565 3565
Misses 385 385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though same problem appears to exist at L1306:
TileDB-SOMA/apis/python/src/tiledbsoma/io/ingest.py
Lines 1305 to 1310 in 33022c6
except (AlreadyExistsError, NotCreateableError): | |
if ingestion_params.error_if_already_exists: | |
raise SOMAError(f"{soma_ndarray.uri} already exists") | |
soma_ndarray = cls.open( | |
uri, "w", platform_config=platform_config, context=context | |
) |
Thanks @ryan-williams ! #2522 |
Issue and/or context: Fixes #2499
Changes:
Notes for Reviewer: The customer callpath wasn't provided in its entirety but it's clear where the bug is