[c++] Add helper methods to convert to ArrowSchema #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3424 +/- ##
==========================================
+ Coverage 86.27% 86.32% +0.04%
==========================================
Files 55 55
Lines 6340 6340
==========================================
+ Hits 5470 5473 +3
+ Misses 870 867 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
previously requested changes
Dec 12, 2024
johnkerl
changed the title
jp-dark
approved these changes
Dec 23, 2024
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/arrow-helpers
branch
from
b9e6046 to
16bb437
Compare
`SOMAColumn` provides an abstraction over TileDB attributes and dimensions and exposes a common interface for all columns regardless of type. Subclasses of `SOMAColumn` can implement complex indexing mechanism through additional dimensions and encapsulate all that logic in one place and make it modular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helpers methods to convert from TileDB dimension and attribute to arrow schema and set current domain.
Issues: sc-59427
Notes for Reviewer:
These methods will be used and tested in the following PR chained of this.