[c++] Column abstraction: SOMAAttribute, part 2
#3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XanthosXanthopoulos
changed the title
SOMAAttribute, part 2
johnkerl
previously requested changes
Dec 12, 2024
XanthosXanthopoulos
force-pushed
the
xan/sc-sc-59427/soma-dimension
branch
from
f134822 to
0ad22da
Compare
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-attribute
branch
2 times, most recently
from
73865cb to
5bcd88d
Compare
jp-dark
approved these changes
Jan 2, 2025
Base automatically changed from
xan/sc-sc-59427/soma-dimension
to
xan/sc-59427/arrow-helpers
January 2, 2025 15:41
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-attribute
branch
from
a215ce4 to
b0a1976
Compare
…nt domain checks, replace vector with span when selecting points
Co-authored-by: Julia Dark <[email protected]>
Co-authored-by: Julia Dark <[email protected]>
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/soma-attribute
branch
from
b0a1976 to
3faefd9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3426 +/- ##
==========================================
+ Coverage 86.27% 86.32% +0.04%
==========================================
Files 55 55
Lines 6340 6340
==========================================
+ Hits 5470 5473 +3
+ Misses 870 867 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce the
SOMAAttributeconcrete class to wrap TileDBAttributeandEnumerationpairs.