-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++, r, python] read_next
clean-up
#3450
[c++, r, python] read_next
clean-up
#3450
Conversation
ManagedQuery::read_next
SOMAArray::read_next
thin wrapper around ManagedQuery::read_next
SOMAArray::read_next
thin wrapper around ManagedQuery::read_next
SOMAArray::read_next
thin wrapper around ManagedQuery::read_next
SOMAArray::read_next
thin wrapper around ManagedQuery::read_next
read_next
clean-up
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3450 +/- ##
===========================================
- Coverage 86.27% 66.55% -19.73%
===========================================
Files 55 139 +84
Lines 6339 18004 +11665
Branches 0 1086 +1086
===========================================
+ Hits 5469 11982 +6513
- Misses 870 5636 +4766
- Partials 0 386 +386
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Although I defer to @bkmartinjr who made the request.
24786ad
to
01eea2b
Compare
01eea2b
to
dc3bb0e
Compare
dc3bb0e
to
f5fe343
Compare
Co-authored-by: nguyenv <[email protected]>
Issue and/or context: #3472
This is a follow-up PR to #3293 which focuses on various clean-up.
Changes:
SOMAArray::read_next
to be a thin wrapper aroundManagedQuery::read_next
sr_complete
to be a thin wrapper aroundSOMAArray::results_complete
setup_read
,submit_read
, andresults
fromclib.ManagedQuery
Notes for Reviewer: