Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++, r, python] read_next clean-up #3450

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Dec 16, 2024

Issue and/or context: #3472

This is a follow-up PR to #3293 which focuses on various clean-up.

Changes:

  • Replace the contents of SOMAArray::read_next to be a thin wrapper around ManagedQuery::read_next
  • Replace the contents of tiledbsoma-r sr_complete to be a thin wrapper around SOMAArray::results_complete
  • Remove dead code setup_read, submit_read, and results from clib.ManagedQuery

Notes for Reviewer:

@nguyenv nguyenv changed the title [r, c++] Replace SOMAArray::read_next contents with ManagedQuery::read_next [r, c++] Make SOMAArray::read_next thin wrapper around ManagedQuery::read_next Dec 16, 2024
@nguyenv nguyenv changed the title [r, c++] Make SOMAArray::read_next thin wrapper around ManagedQuery::read_next [c++, r, python] Make SOMAArray::read_next thin wrapper around ManagedQuery::read_next Dec 16, 2024
@nguyenv nguyenv changed the title [c++, r, python] Make SOMAArray::read_next thin wrapper around ManagedQuery::read_next [c++, r, python] read_next clean-up Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.55%. Comparing base (bda7d97) to head (f5fe343).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3450       +/-   ##
===========================================
- Coverage   86.27%   66.55%   -19.73%     
===========================================
  Files          55      139       +84     
  Lines        6339    18004    +11665     
  Branches        0     1086     +1086     
===========================================
+ Hits         5469    11982     +6513     
- Misses        870     5636     +4766     
- Partials        0      386      +386     
Flag Coverage Δ
libtiledbsoma 55.80% <100.00%> (?)
python 86.32% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.32% <ø> (+0.04%) ⬆️
libtiledbsoma 49.81% <100.00%> (∅)

@nguyenv nguyenv marked this pull request as ready for review December 16, 2024 22:39
@nguyenv nguyenv marked this pull request as draft December 16, 2024 22:39
@nguyenv nguyenv marked this pull request as ready for review December 17, 2024 22:48
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although I defer to @bkmartinjr who made the request.

apis/r/R/ReadIter.R Outdated Show resolved Hide resolved
apis/r/R/ReadIter.R Outdated Show resolved Hide resolved
apis/r/R/ReadIter.R Outdated Show resolved Hide resolved
@nguyenv nguyenv force-pushed the viviannguyen/sc-54744/PASS-PYTHON-FAIL-R-python-soma-read-does-an-open-on-an-already branch from 24786ad to 01eea2b Compare December 18, 2024 04:02
@nguyenv nguyenv force-pushed the viviannguyen/sc-54744/PASS-PYTHON-FAIL-R-python-soma-read-does-an-open-on-an-already branch from 01eea2b to dc3bb0e Compare December 18, 2024 19:08
@nguyenv nguyenv force-pushed the viviannguyen/sc-54744/PASS-PYTHON-FAIL-R-python-soma-read-does-an-open-on-an-already branch from dc3bb0e to f5fe343 Compare December 18, 2024 23:47
@nguyenv nguyenv merged commit 345d596 into main Dec 19, 2024
15 checks passed
@nguyenv nguyenv deleted the viviannguyen/sc-54744/PASS-PYTHON-FAIL-R-python-soma-read-does-an-open-on-an-already branch December 19, 2024 01:46
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
johnkerl pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants