Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Make destructors of base classes virtual #3484

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[c++] Make destructors of base classes virtual #3484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libtiledbsoma/src/geometry/base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ struct BasePoint {
, m(m) {
}

virtual ~BasePoint() = default;

double_t x;
double_t y;
std::optional<double_t> z;
std::optional<double_t> m;
};
} // namespace tiledbsoma::geometry

#endif // TILEDBSOMA_GEOMETRY_BASE_H
#endif // TILEDBSOMA_GEOMETRY_BASE_H
2 changes: 1 addition & 1 deletion libtiledbsoma/src/soma/soma_array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ class SOMAArray : public SOMAObject {
}

SOMAArray() = delete;
~SOMAArray() = default;
virtual ~SOMAArray() = default;

/**
* @brief Get URI of the SOMAArray.
Expand Down
2 changes: 1 addition & 1 deletion libtiledbsoma/src/soma/soma_collection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class SOMACollection : public SOMAGroup {
SOMACollection() = delete;
SOMACollection(const SOMACollection&) = default;
SOMACollection(SOMACollection&&) = default;
~SOMACollection() = default;
virtual ~SOMACollection() = default;

using iterator =
typename std::map<std::string, std::shared_ptr<SOMAObject>>::iterator;
Expand Down
2 changes: 1 addition & 1 deletion libtiledbsoma/src/soma/soma_group.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class SOMAGroup : public SOMAObject {
SOMAGroup() = delete;
SOMAGroup(const SOMAGroup&) = default;
SOMAGroup(SOMAGroup&&) = default;
~SOMAGroup() = default;
virtual ~SOMAGroup() = default;

/**
* Open the SOMAGroup object.
Expand Down