[c++] Show which coordinate is out of range in fastercsx error messages
#3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
fastercsxfastercsx error messages
johnkerl
force-pushed
the
kerl/which-coordinate-out-of-range
branch
from
33fdef6 to
663c506
Compare
bkmartinjr
reviewed
Jan 9, 2025
bkmartinjr
reviewed
Jan 9, 2025
bkmartinjr
reviewed
Jan 9, 2025
bkmartinjr
approved these changes
Jan 9, 2025
|
Thanks @bkmartinjr ! |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
…ages (#3539) * [c++] Show which coordinate is out of range in `fastercsx` * code-review feedback * more
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
==========================================
+ Coverage 86.25% 86.30% +0.04%
==========================================
Files 55 55
Lines 6359 6359
==========================================
+ Hits 5485 5488 +3
+ Misses 874 871 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
added a commit
that referenced
this pull request
Jan 9, 2025
…ages (#3539) (#3541) * [c++] Show which coordinate is out of range in `fastercsx` * code-review feedback * more Co-authored-by: John Kerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-61341]
[sc-61579]