[python] Add Unicode metadata support #3558
Open
+156
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
==========================================
+ Coverage 86.25% 86.26% +0.01%
==========================================
Files 55 55
Lines 6359 6408 +49
==========================================
+ Hits 5485 5528 +43
- Misses 874 880 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up PR to #3548 that adds support for Unicode metadata.
UTF-8 support is not enough to store 1D numpy string arrays because Unicode arrays are by default UTF-32 encoded and can contain NULL bytes.
Additionally improved robustness of metadata writing by attempting to write all modifications and collecting errors throughout the process and raising an exception cumulative at the end, rather than throwing midway.