Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display score change in submissions admin #405

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MasloMaslane
Copy link
Member

Closes #350

@MasloMaslane MasloMaslane marked this pull request as draft September 13, 2024 07:35
@MasloMaslane MasloMaslane marked this pull request as ready for review September 13, 2024 09:27
Copy link
Contributor

@metenn metenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, actions like changing the submission kind will also affect the score diff, which might yield unintended results?

I think you accidentally also formatted some existing test code, which, while objectively better, could be confusing for future git blame's and makes this PR's diff a bit harder to navigate

oioioi/contests/tests/tests.py Outdated Show resolved Hide resolved
oioioi/contests/controllers.py Outdated Show resolved Hide resolved
oioioi/pa/controllers.py Outdated Show resolved Hide resolved
oioioi/contests/admin.py Outdated Show resolved Hide resolved
oioioi/contests/admin.py Show resolved Hide resolved
oioioi/mp/controllers.py Show resolved Hide resolved
@MasloMaslane MasloMaslane requested a review from metenn September 22, 2024 15:24
@MasloMaslane MasloMaslane marked this pull request as draft October 31, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Submission View] Display how many points a contestant gained by submitting this solution
2 participants