Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support localized Spotify URLs #30

Merged
merged 4 commits into from
Nov 12, 2024
Merged

fix: support localized Spotify URLs #30

merged 4 commits into from
Nov 12, 2024

Conversation

fgsalomon
Copy link
Contributor

@fgsalomon fgsalomon commented Nov 12, 2024 •
edited
Loading

I think this should tackle #29

sjdonado
sjdonado approved these changes Nov 12, 2024
View reviewed changes
Copy link
Owner

@sjdonado sjdonado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

Could you please update the package.json version to 1.4.1?

@fgsalomon
Copy link
Contributor Author

Nice catch, thank you!

Could you please update the package.json version to 1.4.1?

Done!

@fgsalomon
chore: use checkout action v4 in GH workflows
0254a76
@fgsalomon
chore: update response ids on tests
6f3b08e 
It looks like now the API returns base64 ids and previosusly not
@sjdonado sjdonado merged commit 61af20e into sjdonado:master Nov 12, 2024
1 check passed
@sjdonado sjdonado mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjdonado sjdonado sjdonado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgsalomon @sjdonado