Package update #99
Merged
Package update #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we were planning on removing anything related to keras, including tests? |
My understanding was that we are skipping keras tests until we update to keras>=3.0 support, and we set that as a low priority. @RemiLehe added the skip flag in the last PR. If we prefer removing it altogether for now, I can push those changes. |
|
I would suggest we remove it altogether, we don't want to claim support until we (or someone else) really need it IMO |
|
@roussel-ryan this is ready. Want to take another look before I merge? |
|
Looks good to me, go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to modern packaging