Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right click image uploads #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Right click image uploads #9

wants to merge 1 commit into from
+381 −154

Conversation

jasonleyser
Copy link
Collaborator

  • Added right click image uploads
  • Restructured the notification toasts to allow for multiple notifications at one time
  • Jumper can be opened/closed while notifications stay visible

@jasonleyser
Right click image uploads
0165fdc 
- Added right click image uploads
- Restructured the notification toasts to allow for multiple notifications
- Jumper can be opened/closed while notifications stay visible
@martinalong
Copy link
Member

image
It allows me to hit "save image" before I'm logged in. Nothing happens when I click it. Maybe it should open the modal and prompt a sign in if you aren't signed in?

@martinalong
Copy link
Member

It looks like you're using the upload endpoint where you have to actually send the file data. There's another endpoint for upload by url where you just send the url of the image and it'll fetch it on its own and save it called /upload-by-url . Just replace the /upload portion of the endpoint you're sending it to with /upload-by-url. And in the data blob, put the url of the file in data.url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinalong martinalong Awaiting requested review from martinalong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonleyser @martinalong