fix(a11y): multiple a11y fixes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torgeadelin
force-pushed
the
feat/emoji-mart/more-a11y-fixes
branch
from
2719972 to
e044514
Compare
torgeadelin
commented
Aug 27, 2024
JanPodmajersky
requested changes
Aug 30, 2024
added 2 commits
August 30, 2024 14:51
- SR & Live Region - add new componet to handle SR annoucements with delay, as focus imput interrupts the annoucements - screen reader announcement no longer announces individual emojis, but rather the count of emojis found OR no emoji found message if none are found - add aria-atomic for the aria-live region to ensure the SR reads the whole message - Navigation - disabled top navigation buttons while search input is focused. This was added because while the input is focused, the tab navigation doesn't do anything in the current implementation, and it can be misleading if not disabled. (user can still hover, and they appear as normal btns). - Search - changed the outer div to a form with role search to improve semantics - add aria-hidden on the loupe icon in the search bar - add aria-label to the search input to be able to give more context if necessary - Search Result & Default Categories - render no result message in the preview section, when preview section is not rendered. previously the no result was only shown in the preview, but since the picker already supports hiding it, we don't want to loose the visual cue of "no emojis found" - add aria-label to the outer div around the all the moji categories - add aria-labelledby for each group of emojis pointing to the section header, and add role = group chore(prettier): fix pretier fix(picker): remove unused func, and add aria-expanded to skin btn chore(pr): address pr comments
torgeadelin
force-pushed
the
feat/emoji-mart/more-a11y-fixes
branch
from
c12ec94 to
33ab48e
Compare
JanPodmajersky
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SR & Live Region
- add new componet to handle SR annoucements with delay, as focus imput interrupts the annoucements
- screen reader announcement no longer announces individual emojis, but rather the count of emojis found OR no emoji found message if none are found
- add aria-atomic for the aria-live region to ensure the SR reads the whole message
Navigation
- disabled top navigation buttons while search input is focused
Search
- changed the outer div to a form with role search to improve semantics
- add aria-hidden on the loupe icon in the search bar
- add aria-label to the search input
Search Result & Default Categories
- render no result message in the preview section, when preview section is not rendered. previously the no result was only shown in the preview, but since the picker already supports hiding it, we don't want to loose the visual cue of "no emojis found"
- add aria-label to the outer div around the all the moji categories
- add aria-labelledby for each group of emojis pointing to the section header, and add role = group