Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CodeLens workflow #150

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Fix: CodeLens workflow #150

merged 12 commits into from
Oct 16, 2024

Conversation

alashchev17
Copy link
Collaborator

Fix: CodeLens workflow

Description

  • Problem: CodeLens in VSCode were lacking of actual chat state, chat window was not opening as expected
  • Solution: Added a handler to get current page from refact-chat-js, fixed issue with file attachment, actual code selection and formatting. Added multiple checks to control chat's behavior in different scenarios
  • Any background context or related links?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, only code improvements)
  • Documentation update

How to Test

  • Edit your customization.yaml, set in every code_lens instruction of auto_submit to false
  • Try to click "Explain" within the code editor's fragment of code
  • Chat should open up a new window and paste the snippet from customization.yaml and place it in a text area.

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated the documentation where necessary.

Linked Issues

  • Relies on #147
  • Closes #456

@alashchev17 alashchev17 self-assigned this Oct 11, 2024
@alashchev17 alashchev17 mentioned this pull request Oct 11, 2024
Merged
12 tasks
@MarcMcIntosh
Copy link
Contributor

Mostly works but I did find an issue when opening chat for the first time, it seems to navigate to the history

bug.mp4

@MarcMcIntosh
Copy link
Contributor

I've added a ticket for the issue
https://github.com/orgs/smallcloudai/projects/5/views/1?pane=issue&itemId=83611508

@MarcMcIntosh MarcMcIntosh force-pushed the fix/codelens_workflow branch from 753be09 to 82840b7 Compare October 16, 2024 11:51
MarcMcIntosh
MarcMcIntosh approved these changes Oct 16, 2024
View reviewed changes
src/chatTab.ts
@@ -976,6 +976,8 @@ export async function chat_model_get(): Promise<[string, string]>
return ["", ""];
}

console.log(`[DEBUG]: context.globalState: `, context.globalState);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the debug statements?

@alashchev17 alashchev17 merged commit 6f9a4dd into dev Oct 16, 2024
12 checks passed
@alashchev17 alashchev17 deleted the fix/codelens_workflow branch October 16, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcMcIntosh MarcMcIntosh MarcMcIntosh approved these changes

@oxyplay oxyplay Awaiting requested review from oxyplay

Assignees

@alashchev17 alashchev17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alashchev17 @MarcMcIntosh @oxyplay @olegklimov