Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat in new tab #46

Merged
merged 17 commits into from
Nov 20, 2023
Merged

Chat in new tab #46

merged 17 commits into from
Nov 20, 2023

Conversation

MarcMcIntosh
Copy link
Contributor

@MarcMcIntosh MarcMcIntosh commented Nov 16, 2023

#40

TODO
[x] render chats in a a new tab
[x] refactor chatTab to handle both the side bar and a tab
[x] improve the ui when the tab gets large.
[x] discuss options for keeping data in sync.
[ ] handle other user flows, (from tab back to side bar chat and possibly others)
[x] disable buttons when waiting for responses

[ ] add padding to the top of the chat tab
[ ] new file should work
[ ] stop should work

User flows

[ ] Click on chat in history -> expand chat in sidebar
[ ] Click on a button on chat in history -> expand chat in tab
[x] Chat in sidebar -> option to move to tab
[ ] Chat in tab -> option to move to sidebar

note:
In order to go from tab to sidebar we'll need to figure out how to programatically close the webview panel. so far I've tried window.close, and tab.dispose with no luck :/

TBD:
Should we add serialisation so the windows persist when the editor is reloaded?
https://code.visualstudio.com/api/extension-guides/webview#serialization

@olegklimov olegklimov marked this pull request as ready for review November 20, 2023 16:21
@olegklimov olegklimov merged commit d98fd48 into v1.2 Nov 20, 2023
7 checks passed
@olegklimov olegklimov deleted the chat-in-new-tab branch November 20, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants