-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat in new tab #46
Merged
Merged
Chat in new tab #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a column but not the active tab :/
…open the tab will enter a generating state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#40
TODO
[x] render chats in a a new tab
[x] refactor chatTab to handle both the side bar and a tab
[x] improve the ui when the tab gets large.
[x] discuss options for keeping data in sync.
[ ] handle other user flows, (from tab back to side bar chat and possibly others)
[x] disable buttons when waiting for responses
[ ] add padding to the top of the chat tab
[ ]
new file
should work[ ]
stop
should workUser flows
[ ] Click on chat in history -> expand chat in sidebar
[ ] Click on a button on chat in history -> expand chat in tab
[x] Chat in sidebar -> option to move to tab
[ ] Chat in tab -> option to move to sidebar
note:
In order to go from tab to sidebar we'll need to figure out how to programatically close the webview panel. so far I've tried window.close, and tab.dispose with no luck :/
TBD:
Should we add serialisation so the windows persist when the editor is reloaded?
https://code.visualstudio.com/api/extension-guides/webview#serialization