Knock off multihit #672
Merged
Knock off multihit #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShivaD173
commented
Dec 31, 2024
ShivaD173
commented
- Make Knock off deal with multi-hit moves correctly
- Make all moves be able to be used multiple times (Needed for calcing other interactions such as 2hko with stamina)
thejetou
reviewed
Jan 2, 2025
src/js/shared_controls.js
Outdated
| } else { | ||
| moveGroupObj.children(".move-hits").hide(); | ||
| moveGroupObj.children(".stat-drops").hide(); | ||
| moveGroupObj.children(".stat-drops").show(); |
There was a problem hiding this comment.
This being in the else block means it won't be shown for multihit moves (is it intentional because of accuracy issues?).
It can be smarter by only showing on moves that do damage, also the class should be renamed because .stat-drops is inaccurate with this change.
There was a problem hiding this comment.
Renamed. This was intentionally not done with multihits because i didn't want to make it too cluttered. This means that there is still at max 1 box active at a time. It is also quite dubious with accuracy, and I can't see where multiple hits and multiple times is useful other than maybe skill link and similar due to the inherent randomness of it.
thejetou
approved these changes
Jan 16, 2025
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.