-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create variants for Java and CDT #10
base: candidate
Are you sure you want to change the base?
Conversation
Can you verify that these changes are still needed and re-roll if necessary? at the least it seems your branch needs to be synchronised before it can be merged. Sorry this PR was abandoned so long... It's fine to close the PR if it isn't still needed |
It seems that Maybe it's even better to publish separate snaps in order to allow parallel installation of different flavors. |
I agree that publishing separate snaps is better. The easiest way to set this up is to create a separate repository for each snap. However, that will make maintaining the snaps a bit harder. It might be better to have multiple versions of the snap in a single repository, so we can update them all in a single PR. However, then we will have to switch from using the snap store build service to GitHub actions, like I'm doing with signal-desktop right now: snapcrafters/signal-desktop#81 If you're interested, I can help you out to set up the GitHub actions once I'm done with signal-desktop. In that case, you would need to update this PR to resolve the conflicts. Two notes:
|
@ThyMYthOS this PR is a little stale, but there might be an alternative route now. Our CI now supports publishing to multiple tracks where each track is represented by a different branch in the repo. We could theoretically have 1 @merlijn-sebrechts wdyt? |
We can use components? |
Not sure if we can have several variants in the same git repo.