Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-715524: Add SSO token cache #921

Open
wants to merge 104 commits into
base: master
Choose a base branch
from
+894 −152

Merge branch 'master' into SNOW-715524-SSO-Token-Cache

126e337
Select commit
Loading
Failed to load commit list.
Open

SNOW-715524: Add SSO token cache #921

Merge branch 'master' into SNOW-715524-SSO-Token-Cache
126e337
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 0s

87.23% (+1.53%) compared to c3cb344

View this Pull Request on Codecov

87.23% (+1.53%) compared to c3cb344

Details

Codecov Report

Attention: Patch coverage is 92.53333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 87.23%. Comparing base (c3cb344) to head (126e337).

Files with missing lines Patch % Lines
Snowflake.Data/Core/Tools/BrowserOperations.cs 5.55% 17 Missing ⚠️
...astructure/SFCredentialManagerWindowsNativeImpl.cs 92.15% 2 Missing and 2 partials ⚠️
...Core/Authenticator/ExternalBrowserAuthenticator.cs 96.96% 3 Missing ⚠️
...ager/Infrastructure/SFCredentialManagerFileImpl.cs 98.09% 0 Missing and 2 partials ⚠️
...re/CredentialManager/SFCredentialManagerFactory.cs 95.83% 0 Missing and 1 partial ⚠️
Snowflake.Data/Core/Session/SFSession.cs 96.15% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   85.70%   87.23%   +1.53%     
==========================================
  Files         117      122       +5     
  Lines       11331    11614     +283     
  Branches     1130     1158      +28     
==========================================
+ Hits         9711    10132     +421     
+ Misses       1342     1196     -146     
- Partials      278      286       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov