close httpClient when closing simpleIngestManager

[sfc-gh-xhuang]

Merging pr from @nirutgupta

#930

The CloseableHttpResponse is closed with try catch (ref), but the client itself is not getting closed, in case if exception is thrown here. This is causing connection leaks, timeout errors and decrease in throughput.

Added the fix to close the httpClient in SimpleIngestManager close() method.

Will add ingestManager.close() here post this change.

[sfc-gh-japatel]

Are we okay doing this way (cloning the PR and opening again), should we need CLA signed from author? @sfc-gh-xhuang

[sfc-gh-xhuang]

@sfc-gh-japatel Confluent has a CLA already

[sfc-gh-tzhang]

This is Snowpipe, we will need Snowpipe folks to review the change

[sfc-gh-xhuang]

@sfc-gh-tzhang I've asked Snowpipe team to take a look for approval but it seems the failing test is a streaming test?

[sfc-gh-tzhang]

@sfc-gh-tzhang I've asked Snowpipe team to take a look for approval but it seems the failing test is a streaming test?

Yes, the failure can be ignored, I have asked Alec to take a look since his PR has the same failure, does look like a real issue