Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW: Fix daily precommit test #2643

Merged
merged 5 commits into from
Nov 19, 2024
Merged

NO-SNOW: Fix daily precommit test #2643

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82e3e6c
Add reset configs to test
sfc-gh-aalam Nov 18, 2024
f2ba8a5
fix lint
sfc-gh-aalam Nov 18, 2024
662294f
fix test in cte disabled mode
sfc-gh-aalam Nov 18, 2024
c491745
try fix
sfc-gh-aalam Nov 19, 2024
0036ade
try fix
sfc-gh-aalam Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/integ/test_multithreading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
)


@pytest.fixture(scope="module")
@pytest.fixture(scope="function")
def threadsafe_session(
db_parameters,
session,
Expand Down Expand Up @@ -684,7 +684,7 @@ def change_config_value(session_):
run=False,
)
def test_large_query_breakdown_with_cte(threadsafe_session):
bounds = (300, 600) if threadsafe_session.sql_simplifier_enabled else (60, 90)
bounds = (300, 600) if threadsafe_session.sql_simplifier_enabled else (50, 70)
try:
original_query_compilation_stage_enabled = (
threadsafe_session._query_compilation_stage_enabled
Expand Down Expand Up @@ -763,8 +763,7 @@ def apply_filter_and_collect(df, thread_id):

assert len(queries["queries"]) == 2
assert queries["queries"][0].startswith("CREATE SCOPED TEMPORARY TABLE")
if threadsafe_session.sql_simplifier_enabled:
assert queries["queries"][1].startswith("WITH SNOWPARK_TEMP_CTE_")
assert queries["queries"][1].startswith("WITH SNOWPARK_TEMP_CTE_")

assert len(queries["post_actions"]) == 1
assert queries["post_actions"][0].startswith("DROP TABLE If EXISTS")
Expand Down
Loading