SNOW-1794373: Support DataFrameWriter.insertInto/insert_into #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage-data-frame-writer-insert-into
sfc-gh-aling
requested review from
sfc-gh-yuwang,
sfc-gh-aalam and
sfc-gh-jrose
Comment on lines
+942
to
+944
| full_table_name = ( | ||
| table_name if isinstance(table_name, str) else ".".join(table_name) | ||
| ) |
There was a problem hiding this comment.
reminder to add a TODO to built ast for this API https://snowflakecomputing.atlassian.net/browse/SNOW-1489960
Comment on lines
+951
to
+954
| if target_table.schema != self._dataframe.schema: | ||
| raise SnowparkClientException( | ||
| f"Schema of the DataFrame: {self._dataframe.schema} does not match the schema of the table {full_table_name}: {target_table.schema}." | ||
| ) |
There was a problem hiding this comment.
I'm not sure if we should do this check on the client side. I think it is possible to append the data by type coercion even though the schemas are not an exact match.
| parse_table_name(table_name) if isinstance(table_name, str) else table_name | ||
| ) | ||
|
|
||
| target_table = self._dataframe._session.table(qualified_table_name) |
There was a problem hiding this comment.
does it work in pyspark even when table does not exist? I think this would fail if table doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Implement DataFrameWriter.insert_into/insertInto which adds dataframe content to existing table requiring same schema;
https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.DataFrameWriter.insertInto.html
support in both live and local testing mode