Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soda Experience first commit, splash screen, project intro and navigation #702

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

prostil
Copy link

@prostil prostil commented Mar 21, 2023

SODA Experience first commit, following features implemented

  • Project scaffolding
  • Splash screen
  • Project intro
  • Navigation to project details

Fixes #699

@anvithks
Copy link
Member

@prostil Could you please share some screenshots ?
It will help in review as the CI still needs to be setup for this.
Thanks.

@anvithks anvithks added the feature New feature label Mar 21, 2023
@anvithks anvithks changed the title Soda Experience first commit, splash screen, project intro and navgat… Soda Experience first commit, splash screen, project intro and navigation Mar 21, 2023
Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comments added.

@@ -0,0 +1,41 @@
{
"name": "sodaexp",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SODA Experience

@@ -0,0 +1,41 @@
{
"name": "sodaexp",
"version": "0.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 0.0.0 -> 0.0.1

Copy link
Author

@prostil prostil Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These I will update in the next PR, this is the base code, do let me know if these changes have to be made right now

@anvithks anvithks merged commit ebe3edc into sodafoundation:soda-experience Mar 21, 2023
@anvithks
Copy link
Member

Thanks Prostil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants