Better exception handling #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emil-bar
force-pushed
the
throw-unchecked-exception-wrapper-instead-of-ee
branch
from
8dc65a4 to
e5f2092
Compare
* unwrap JoxScopeExecutionException in flows * add `unwrapAndThrow` utility method * updated java docs and readme
emil-bar
force-pushed
the
throw-unchecked-exception-wrapper-instead-of-ee
branch
from
e5f2092 to
8e29147
Compare
adamw
reviewed
Jan 15, 2025
adamw
reviewed
Jan 22, 2025
| @@ -1678,6 +1676,10 @@ public void runToFile(Path path) throws Exception { | |||
| } | |||
| }); | |||
| close(channel, null); | |||
| } catch (JoxScopeExecutionException e) { | |||
| Exception cause = (Exception) e.getCause(); | |||
| close(channel, cause); | |||
There was a problem hiding this comment.
maybe I merged too fast ;) shouldn't we not-unwrap here as well?
There was a problem hiding this comment.
Hmm, I might have missed that bit, let me open another PR to revert it as well
|
(sorry, comment for the wrong PR earlier) thanks for the work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59