forked from Tencent/Hippy
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ohos): add jsi module #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohotz
reviewed
Dec 11, 2024
driver/js/src/napi/jsh/jsh_ctx.cc
Outdated
static JSVM_Value GetPropertyCbInfo(JSVM_Env env, JSVM_Value name, JSVM_Value thisArg, JSVM_Value data) { | ||
char strValue[100]; | ||
size_t size; | ||
OH_JSVM_GetValueStringUtf8(env, name, strValue, 300, &size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
临时代码?
driver/js/src/napi/jsh/jsh_ctx.cc
Outdated
|
||
JSVM_Value res = nullptr; | ||
OH_JSVM_CreateBigintWords(env_, 1, 2, reinterpret_cast<const uint64_t *>(constructor_wrapper.get()), &res); | ||
JSVM_PropertyHandlerConfigurationStruct* propertyHandlerCfg = new JSVM_PropertyHandlerConfigurationStruct(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没delete
sohotz
pushed a commit
that referenced
this pull request
Jan 15, 2025
* feat(ohos): add jsi init * add turboMoudule with cpp version * feat(ohos): add turbo module * feat(vue): update vue bundle * feat(ohos): add jsi for jsvm * feat(ohos): add jsi for jsvm * feat(ohos): fix crash * feat(ohos): jsi clean code * feat(ohos): jsi clean code --------- Co-authored-by: PC-GRRPM211\Administrator <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: