fix: static-store setValue with setterFn has correct arguments (#734)

solidjs-community · Jan 10, 2025 · 415064d · 415064d
2 parents 71f6c5e + 56d9511
commit 415064d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/silent-paws-approve.md b/.changeset/silent-paws-approve.md
@@ -0,0 +1,5 @@
+---
+"@solid-primitives/static-store": patch
+---
+
+fix: static-store setValue with setterFn has correct arguments
diff --git a/packages/static-store/src/index.ts b/packages/static-store/src/index.ts
@@ -68,7 +68,7 @@ export function createStaticStore<T extends object>(
   const setValue = (key: keyof T, value: SetterParam<any>): void => {
     const signal = cache[key];
     if (signal) return signal[1](value);
-    if (key in copy) copy[key] = accessWith(value, [copy[key]]);
+    if (key in copy) copy[key] = accessWith(value, copy[key]);
   };
 
   return [

diff --git a/packages/static-store/test/index.test.ts b/packages/static-store/test/index.test.ts
@@ -32,6 +32,9 @@ describe("createStaticStore", () => {
         d: [0, 1, 2],
       });
 
+      setState('a', prev => prev + 1);
+      expect(state.a).toBe(10);
+
       createEffect(() => {
         state.a;
         aUpdates++;