-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data Fetching Guide #991
base: main
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @amirhhashemi, First of all, thank you for taking the time to work on this, I appreciate the time you're taking out of your day to improve our documentation. It might be useful to take a look at the diataxis documentation on how guides should be written. We use this as a reference for writing our docs, and i feel like it could be helpful to consider for this! If you'd like some more directed feedback, however, please let me know |
Thank you for the feedback. I made some changes based on the diataxis guide:
I'm not sure about:
|
Thank you for adding some changes! One comment I do want to make, is that I think adding back some (basic) explanations can be helpful. Doesn't have to explain anything but the process, such as this:
This way it follows we have the code snippet explained a bit in case users need some kind of explanation (but not giving too much background about the topic itself, which is more appropriate for other sections in the docs). This is a pretty rough example but we can either have it as a quick list (if you feel it's necessary) or just a simple explanation of how things are set up in the snippet. I do agree that, to an extent, having each section self-contained is important. We don't want them so far removed that they could be considered separate entirely, but enough that there is some relationship (even if marginally). As for the Tanstack Query section, I do agree that it would probably be better suited for a tutorial than in here. That being said, a callout could probably replace the section saying something as simple as what you wrote for the first sentence:
Do you have any questions/ comments about what I mentioned? |
Thank you for the feedback. I've added basic explanations for each section. However, I have some concerns:
I would appreciate your feedback on these points. Please feel free to edit the document directly if needed. Regarding Tanstack Query: I've removed the dedicated section and added a brief note about it at the end of the |
I'm wondering whether we should remove the "how to" from section titles:
The way this guide is written, it's obvious we are only talking about how to do stuff, and not why and when. I think we can remove it. What do you think? |
@amirhhashemi Thank you for adding the explanations! I'll try and get to reviewing them this weekend (and seeing how we can approach the createResource section) but I wanted to say I think it's a great Idea to update the titles to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know how you feel about these changes, but I feel like you did a great job explaining each code snippet briefly.
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
Co-authored-by: Sarah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
I just had those 2 small comments / nitpicks
Description
The idea of the Guides section is to provide a resource for developers who don't read Solid.js and Solid Router docs before learning SolidStart, such as React developers who may think of SolidStart as what Next.js is for React and start learning Solid.js from SolidStart. However, I think a Guides section can be useful to a lot of people regardless of whether they come from React.
The goal is to get those users (or anyone really) up and running with SolidStart as quickly as possible, while also guiding them to read more relevant docs if they want to learn more.
This PR adds a Data Fetching page under the Guides section that covers basic data fetching patterns while providing links to relevant documentation for those who want to learn more.
See #861 for more context.
Related issues & labels
#914 #861