adds comments about confusing test mode nomenclature mis-match… #26
Conversation
|
since test_mode is defined on the base objects, I don't see anyway to 'take it off' these two objects (where it really shouldn't exist). As a compromise, I've made it default to false with comments as warning messages that its meaning is different for Authorize .Net than from the other payment gateways and to warn people to make sure their 'preferred server' is set to either 'live' or 'test' |
…n gateway code and Auth .Net; also adds ActiveSupport deprecation notice if you fail to have your preferred server set to 'live' or 'test'; defaults to 'live' gateway with test-mode set to false (also set test mode to false; unlike other gateways, it does not determine if the test server is used) adding test_mode set to false by default with message about overloading the base class's implementation
|
@Senjai -- since I can't remove it, I've added it with |
| # DO NOT TURN TEST MODE TO ON (EVEN IN QA/STAGING ENVIRONMENTS), it will return 0 as transaction ids under all circumstances | ||
|
|
||
| # here, it overloads the setting on the base class, which confusingly defaults to true | ||
| preference :test_mode, :boolean, :default => false |
There was a problem hiding this comment.
If we want this to always be false, maybe we should override the implementation of preferred_test_mode to always return false.
between gateway code and Auth .Net; also adds ActiveSupport deprecation notice if you fail to have your preferred server set to 'live' or 'test'; defaults to 'live' gateway with test-mode set to false (also set test mode to false; unlike other gateways, it does not determine if the test server is used)