Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified & Updated remixicon.symbol.svg #397

Closed
wants to merge 2 commits into from

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Dec 18, 2024

Updated the icon library

Summary

The icon library was outdated, we updated it to provide some icons for social auth.

Fixes: #396
Prepares for: #395

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Updated the icon library
@fthobe
Copy link
Contributor Author

fthobe commented Dec 18, 2024

We should consider in general if we want to reduce the file size by removing unused icons.
It was already 800kb before and now it's on 1.6MB

@fthobe fthobe changed the title Minifed & Updated remixicon.symbol.svg Minified & Updated remixicon.symbol.svg Dec 18, 2024
@fthobe fthobe closed this Dec 18, 2024
@fthobe
Copy link
Contributor Author

fthobe commented Dec 20, 2024

Upon careful consideration I have reworked #396 and do not think that an update would be the right road

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate reduced remixicon sprite
1 participant