Improve scanning coverage calculation #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanman-sonatype
merged commit 2002feb
into
sonatype-nexus-community:develop
2 checks passed
rpanman-sonatype
added a commit
that referenced
this pull request
Feb 3, 2024
rpanman-sonatype
added a commit
that referenced
this pull request
Feb 27, 2024
* Revert "Revert "Fix Windows Docker command"" * Updated get-metrics start time period (#115) * Merge develop to main for release 102 (#119) * Updated get-metrics start time period (#114) * Improve scanning coverage calculation (#118) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix StringIndexOutOfBoundsException and add logging * Removed unecessary lines from test --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the scanning coverage calculation uses the total number of applications at the end of the period
when calculation scanning coverage - this can lead to misleading results if the number of applications is
increasing from period to period (underestimating scanning coverage if the application count is increasing).
After this PR the scanning coverage calculation calculates the ratio of scanned/total applications for each
period and then averages that ratio across the whole period.