#420: More operations in string theory #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unicode characters were not handled in the same way in SMT solvers. Z3, CVC4, and CVC5 require proper escaping. Z3 also supports Java-based Unicode characters. Princess only allows 16bit-sized Unicode, i.e., up to 0x0FFFF, which misses surrogate pairs up to 0x2FFFF as defined in SMTLIB.
There was a problem hiding this comment.
Looks good to me! There is some overlap with #412, but I think it's fine to do it as part of this pull request.
And I think we still need to add the new operations to FunctionDeclarationKind for the visitor?
src/org/sosy_lab/java_smt/basicimpl/AbstractStringFormulaManager.java
Outdated
Show resolved
Hide resolved
src/org/sosy_lab/java_smt/basicimpl/AbstractStringFormulaManager.java
Outdated
Show resolved
Hide resolved
This was referenced Dec 30, 2024
kfriedberger
commented
Dec 31, 2024
| @@ -300,6 +300,8 @@ public enum FunctionDeclarationKind { | |||
| STR_IN_RE, | |||
| STR_TO_INT, | |||
| INT_TO_STR, | |||
| STR_FROM_CODE, | |||
| STR_TO_CODE, | |||
| STR_LT, | |||
There was a problem hiding this comment.
I added the mentioned operations already here.
And Junit tests assure that the operations are visited correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for conversion between strings and integers based on code points.
See #420 for the requirement of this API extension in String theory.
Open issues from here: