WIP: open rocksdb in rw mode so that old databases can be upgraded #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
manysearchandfastmultigatherso that when searching against a RocksDB, they will automatically upgrade the internal RocksDB format from older versions. This is as simple as opening them in read/write mode instead of read-only mode.I must admit it gives me the heeby jeebies to open a database in rw mode unnecessarily, but in @luizirber we trust? :) An alternative would be to keep the database in ro mode when searching and have the
checkcommand upgrade the database... Thoughts?Fixes #580
TODO