Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing c:v to vcodec and c:a to acodec to avoid remux error in postprocess #491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ladida1
Copy link

@Ladida1 Ladida1 commented Oct 31, 2016

This is my first ever PR, so I hope I got it right.

This PR solves the issue I had with remuxing or merging the audio and video streams.
#437

I don´t know why c:v and a:v doesn´t work on my system, as they are options that should work. So you might not want to pick this PR. Anyway thought I should share it.

@spaam
Copy link
Owner

spaam commented Oct 31, 2016

looks good. but few questions.
i guess you have an old version of ffmpeg? if so, does "-bsf:a aac_adtstoasc" work that version? :)

@Ladida1
Copy link
Author

Ladida1 commented Nov 1, 2016

I will test and see if it works.

How do I get a good test file with that codec?
SVTPlan and a TS file? Would that be HLS?

@spaam
Copy link
Owner

spaam commented Nov 1, 2016

TS file . but we have some more things in the postprocess thing. for example merge .srt files into the .mp4 file. what version do you have? dist? os?

@Ladida1
Copy link
Author

Ladida1 commented Nov 2, 2016

I have ffmpeg version 0.8.17-6:0.8.17-2+deb7u2.
OS is Linux, Debian 7.6

Maybe that is to old? Then we can close the PR and I keep the patch in my fork.

I have trouble finding good test files from SVT and I also stumbled upon another issue while remuxing .ts files (error "Failed to set value 'copy' for option 'c'").

@iwconfig
Copy link
Contributor

iwconfig commented Dec 28, 2016

I did some research a while ago and '-c:v/a/s' is not supported until version 1.0. I did tests with multiple versions of ffmpeg and also found that '-map' and '-metadata' options require at least version 1.0 for the subtitles to merge. With regards to the facts, I really can't see any reason not to upgrade ffmpeg to the latest release (3.2.2). I get it of course, the average user maybe isn't familiar with the technicalities in updating something of that sort, which is why I've started working on implementing an ffmpeg installer if version is below 1.0 or nonexistent. I will pr it sometime in the future when I have time.

I will double check the version dependency tomorrow in case I forgot something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants