Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary DirtyField() calls #5620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ElectroJr
Copy link
Member

Small collection of miscellaneous physics & delta state changes:

  • Makes the client's DirtyField() check IGameTiming.InPrediction
  • Makes various setter methods in PhysicsSystem check the dirty bool
    • I'm not sure why, but they were all removed in Add sourcegenned field deltas #5155
    • I'm not even sure if they're required if InPrediction gets checked, but might keep using the argument while it exists.
  • Adds a new DirtyFields() method for simultaneously marking several fields as dirty.
    • I love params ReadOnlySpan<>
  • Sets PhysicsComponent.Force to zero when changing body type. I think this was just accidentally removed in Add sourcegenned field deltas #5155?

This PR also removes the Pure attribute from the EntityQuery<T>.Resolve() methods, making them them consistent with the other Resolves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant