HLA-1348: Isolate dependencies to optional dependencies list if possible #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-goldman
changed the title
mdlpstsci
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
These changes look fine to me. As long as you are sure that tables is an optional dependency, then I am fine with this PR. I could not find where typing_extensions and markupsafe were used anywhere, though I do remember markupsafe caused us trouble in the past!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1348
Closes #1895
This PR removes unused dependencies from the main dependencies list in the pyproject.toml file. Several dependencies are moved to the optional dependencies list.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionHow to run regression tests on a PR
jenkins test