Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure user-specified metadata isn't blown away by default metadata. #174

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

schlafly
Copy link
Collaborator

Closes #173. Larry identified an issue where we were overwriting the intended metadata with default metadata instead of the other way around; this PR changes the order of things to avoid that goof.

@larrybradley, I went ahead and updated the files on /grp/roman/eschlafly/romanisim/ in place to fix this. The actual data also likely changed since I suspect that I was actually just simulating the same filter repeatedly; thank you!

@schlafly schlafly requested a review from a team as a code owner November 13, 2024 21:19
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (81028a8) to head (140ca6e).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   89.24%   91.04%   +1.80%     
==========================================
  Files          17       16       -1     
  Lines        2073     2100      +27     
==========================================
+ Hits         1850     1912      +62     
+ Misses        223      188      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly schlafly merged commit 240e9a4 into spacetelescope:main Nov 14, 2024
20 checks passed
@schlafly schlafly deleted the fix-l3-metadata branch November 14, 2024 18:25
eunkyuh pushed a commit to eunkyuh/romanisim that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta optical_element is always set to 'F158'
1 participant