-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix floating point issues #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks great!
FYI, I need to diagnose the failing lon/lat tests ~now but they are unrelated to this PR. |
@farkmarnum , I resolved the issues with tests so now the tests work. Everything passes except for the -oldestdeps test, which fails. |
It looks like the behavior of I just pushed a fix to this branch. |
Great. Thanks! All tests are passing, merging. |
This fixes #193 using the solution described in that issue.
I've also added a test for the case causing the error -- even though the error only occurs on some architectures, there's always a warning from numpy about the potential overflow, so the test checks for that.