Minor fix to clarify user-provided position angle instead of roll

[Skyhawk172]

After some testing and discussion, it has become clear(er) that the user-provided --roll argument is really the position angle measured at the aperture's V2Ref/V3Ref (measured from North to YIdl). The handling of this value in wcs.py was also fixed for the case where the aperture used is BORESIGHT.

Note that the code in wcs.py converts this value to roll_ref, which is defined as the angle from North to V3 (towards East) measured at the aperture V2Ref/V3Ref, but from a user perspective, it makes more sense to specify the position angle of the aperture on the sky, hence the clarification provided here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a31e25) 92.59% compared to head (7798e70) 92.59%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          16       16           
  Lines        1471     1471           
=======================================
  Hits         1362     1362           
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[schlafly]

Great. Thanks for catching both uses of roll in romanisim-make-image and romanisim-make-stack. Merging!