Addded front-end only image upload dialog #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our project, the Cardiac Electrophysiology Web Lab I'm working on a feature that needs a markdown editor. SImplemde did mostly what I wanted which is great. However I didn't like the way in handles images. So I changed drawImage to pop up a dialog where you can either put a url op 'upload' an image. The upload gets embedded inside the markdown as inscary encoded string, as for various reasons I didn't fancy doing it via the back-end.
I thought this might also somewhat fit #190 and #328, so I thought I'd share my 2 cents. feel free to do wit it whatever you see fit!