Fix box-selection bug #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a box-selection bug in the
spectrum-deploy-lm-pooltoolPool deployment involves a chain of 6 transactions. The first one always succeeds and it makes sure to create an output box
B_0that contains exactly the amount of ERGs necessary as input for the 2nd TX. Now the code before this PR always assumed that the onlyB_0would be selected as input for the 2nd TX and it has worked this way for quite a while.But we've now come across an example where this does not happen, leading to a mismatch of input and output ERGs for the TX. This PR removes that assumption relating to box-selection, as well manually checking for parity between input/output ergs for each TX in the chain.
Other changes
max_rounding_error(from Alex Oranov Update LqMiningSimple.md ergo-dex#40)