Add and improve the e2e use case of the NIC where the default route is located #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
debug log: |
cyclinder
reviewed
Oct 16, 2023
| Expect(err).NotTo(HaveOccurred(), "failed to execute command, error is: %v ", err) | ||
| Expect(string(executeCommandResult)).Should(ContainSubstring(common.NIC1), "Expected NIC %v mismatch", common.NIC1) | ||
|
|
||
| // ip r get <IP in net1 subnet>, should flow out from net1 |
There was a problem hiding this comment.
是否还可以加个 ip r get <service_subnet>
Codecov Report
@@ Coverage Diff @@
## main #2425 +/- ##
=======================================
Coverage 80.97% 80.97%
=======================================
Files 49 49
Lines 5251 5251
=======================================
Hits 4252 4252
Misses 842 842
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
force-pushed
the
e2e/new-3
branch
2 times, most recently
from
dc36928 to
00dffd8
Compare
|
is this ready for merge ？ |
|
it could add commit together to pr for CI |
ty-dc
force-pushed
the
e2e/new-3
branch
3 times, most recently
from
bdb43b7 to
67728fe
Compare
ty-dc
force-pushed
the
e2e/new-3
branch
6 times, most recently
from
5652af4 to
f24ed02
Compare
…s located Signed-off-by: ty-dc <[email protected]>
cyclinder
requested changes
Oct 18, 2023
cmd/coordinator/cmd/utils.go
Outdated
| if defaultInterfaceRoutes[idx].Family == netlink.FAMILY_V6 { | ||
| zeroIPAddress = net.IPv6zero | ||
| } | ||
| if route.Dst != nil || !route.Dst.IP.Equal(zeroIPAddress) { |
There was a problem hiding this comment.
if !route.Dst.IP.Equal(zeroIPAddress) {
cmd/coordinator/cmd/utils.go
Outdated
| if defaultInterfaceRoutes[idx].Family == netlink.FAMILY_V6 { | ||
| zeroIPAddress = net.IPv6zero | ||
| } | ||
| if route.Dst != nil || !route.Dst.IP.Equal(zeroIPAddress) { |
There was a problem hiding this comment.
if !route.Dst.IP.Equal(zeroIPAddress) {
Signed-off-by: ty-dc <[email protected]>
cyclinder
reviewed
Oct 18, 2023
| @@ -179,6 +179,15 @@ setup_spiderpool: | |||
| fi ; \ | |||
| if [ "$(E2E_SPIDERPOOL_ENABLE_COORDINATOR)" == "true" ] ; then \ | |||
| HELM_OPTION+=" --set coordinator.enabled=true " ; \ | |||
| if [ "$(INSTALL_CILIUM)" == "true" ] ; then \ | |||
There was a problem hiding this comment.
OK, restoring this part of the code after the #2434 merge will also help verify the problem.
cyclinder
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The changes are as follows:
Add a new case. Without setting any annotations or PodDefaultRouteNIC (default situation), the default route should be on net1.
Change the existing use case, specify PodDefaultRouteNIC as eth0, and check that the default route should be on eth0
Which issue(s) this PR fixes:
make sure your commit is signed off
Signed-off-by: ty-dc [email protected]