e2e-fix: Use the default calico version when getting the calico version fails #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizhoublue
reviewed
Dec 8, 2023
test/Makefile.defs
Outdated
| @@ -130,6 +130,7 @@ E2E_MULTUS_IMAGE_NAME ?= $(E2E_MULTUS_IMAGE_REGISTER)/k8snetworkplumbingwg/multu | |||
|
|
|||
| #================= calico | |||
| CALICO_VERSION ?= | |||
| MAMUAL_CALICO_VERSION ?= v3.26.4 | |||
There was a problem hiding this comment.
名字有歧义
DEFAULT_CALICO_VERSION
…on fails Signed-off-by: tao.yang <[email protected]>
ty-dc
force-pushed
the
ci/fix-calico-version
branch
from
2e6695c to
a757ee6
Compare
ty-dc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
e2e-fix: specify the calico version manually when failed to retrieve it specify the calico version manually when failed to retrieve it
Which issue(s) this PR fixes:
close #2718
Special notes for your reviewer: