Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpiderMultusConfig: support empty config with custom type #2862

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Icarus9913
Copy link
Collaborator

Looking back this issue: #2438
The reason that make the below yaml applied is that the webhook not works by a Webhook configuration mistake that I made, refer to #2067

cat <<EOF | kubectl apply -f -
apiVersion: spiderpool.spidernet.io/v2beta1
kind: SpiderMultusConfig
metadata:
  name: cilium
  namespace: kube-system
EOF

The fix #2438 makes no sense, because we already set the property CniType as a Required field

// MultusCNIConfigSpec defines the desired state of SpiderMultusConfig.
type MultusCNIConfigSpec struct {
	// +kubebuilder:validation:Required
	// +kubebuilder:validation:Enum=macvlan;ipvlan;sriov;ovs;custom
	CniType string `json:"cniType"`

Signed-off-by: Icarus9913 [email protected]

@Icarus9913 Icarus9913 added pr/ready-review This pull is ready for review enhancement source codes enhancement release/none no release note labels Dec 13, 2023
@Icarus9913 Icarus9913 requested a review from cyclinder December 13, 2023 10:29
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #2862 (2833db7) into main (fe936b5) will increase coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
+ Coverage   81.09%   81.15%   +0.05%     
==========================================
  Files          49       49              
  Lines        5333     5333              
==========================================
+ Hits         4325     4328       +3     
+ Misses        852      850       -2     
+ Partials      156      155       -1     
Flag Coverage Δ
unittests 81.15% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Icarus9913 Icarus9913 changed the title optimize spider multus config operator optimize spider multus config operator codes Dec 13, 2023
@Icarus9913 Icarus9913 force-pushed the fix/wk/spider-multus-config branch from c552bcb to bb6d37d Compare December 14, 2023 02:55
@Icarus9913 Icarus9913 added release/feature-new release note for new feature and removed enhancement source codes enhancement labels Dec 14, 2023
@Icarus9913 Icarus9913 force-pushed the fix/wk/spider-multus-config branch 2 times, most recently from 4a3168a to 16b981d Compare December 14, 2023 06:33
@Icarus9913 Icarus9913 linked an issue Dec 14, 2023 that may be closed by this pull request
@Icarus9913 Icarus9913 force-pushed the fix/wk/spider-multus-config branch from 16b981d to a2464bc Compare December 14, 2023 07:48
@weizhoublue weizhoublue changed the title optimize spider multus config operator codes SpiderMultusConfig: support empty config with custom type Dec 14, 2023
@Icarus9913 Icarus9913 added the pr/not-ready not ready for merging label Dec 15, 2023
@Icarus9913 Icarus9913 force-pushed the fix/wk/spider-multus-config branch 2 times, most recently from 12ebc3c to 4388efa Compare December 15, 2023 10:04
@Icarus9913 Icarus9913 added cherrypick-release-v0.9 and removed pr/not-ready not ready for merging release/none no release note labels Dec 15, 2023
@Icarus9913 Icarus9913 force-pushed the fix/wk/spider-multus-config branch from 4388efa to 2833db7 Compare December 15, 2023 10:15
@ty-dc ty-dc merged commit 11c4972 into spidernet-io:main Dec 18, 2023
43 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
SpiderMultusConfig: support empty config with custom type
@Icarus9913 Icarus9913 deleted the fix/wk/spider-multus-config branch December 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v0.9 pr/ready-review This pull is ready for review release/feature-new release note for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpiderMultusConfig resource with empty spec empty spidermultusconfig and crash
3 participants