-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpiderMultusConfig: support empty config with custom type #2862
Merged
ty-dc
merged 1 commit into
spidernet-io:main
from
Icarus9913:fix/wk/spider-multus-config
Dec 18, 2023
Merged
SpiderMultusConfig: support empty config with custom type #2862
ty-dc
merged 1 commit into
spidernet-io:main
from
Icarus9913:fix/wk/spider-multus-config
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
added
pr/ready-review
This pull is ready for review
enhancement
source codes enhancement
release/none
no release note
labels
Dec 13, 2023
Icarus9913
requested review from
weizhoublue,
ty-dc and
bzsuni
as code owners
December 13, 2023 10:29
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
==========================================
+ Coverage 81.09% 81.15% +0.05%
==========================================
Files 49 49
Lines 5333 5333
==========================================
+ Hits 4325 4328 +3
+ Misses 852 850 -2
+ Partials 156 155 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Icarus9913
changed the title
optimize spider multus config operator
optimize spider multus config operator codes
Dec 13, 2023
Icarus9913
force-pushed
the
fix/wk/spider-multus-config
branch
from
December 14, 2023 02:55
c552bcb
to
bb6d37d
Compare
Icarus9913
added
release/feature-new
release note for new feature
and removed
enhancement
source codes enhancement
labels
Dec 14, 2023
Icarus9913
force-pushed
the
fix/wk/spider-multus-config
branch
2 times, most recently
from
December 14, 2023 06:33
4a3168a
to
16b981d
Compare
Icarus9913
force-pushed
the
fix/wk/spider-multus-config
branch
from
December 14, 2023 07:48
16b981d
to
a2464bc
Compare
weizhoublue
changed the title
optimize spider multus config operator codes
SpiderMultusConfig: support empty config with custom type
Dec 14, 2023
Icarus9913
force-pushed
the
fix/wk/spider-multus-config
branch
2 times, most recently
from
December 15, 2023 10:04
12ebc3c
to
4388efa
Compare
Icarus9913
added
cherrypick-release-v0.9
and removed
pr/not-ready
not ready for merging
release/none
no release note
labels
Dec 15, 2023
Signed-off-by: Icarus9913 <[email protected]>
Icarus9913
force-pushed
the
fix/wk/spider-multus-config
branch
from
December 15, 2023 10:15
4388efa
to
2833db7
Compare
weizhoublue
approved these changes
Dec 15, 2023
ty-dc
approved these changes
Dec 18, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
SpiderMultusConfig: support empty config with custom type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherrypick-release-v0.9
pr/ready-review
This pull is ready for review
release/feature-new
release note for new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking back this issue: #2438
The reason that make the below yaml applied is that the webhook not works by a Webhook configuration mistake that I made, refer to #2067
The fix #2438 makes no sense, because we already set the property
CniType
as aRequired
fieldSigned-off-by: Icarus9913 [email protected]