Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add spidercoodinator e2e for spiderpool #2927

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Dec 15, 2023

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@ty-dc ty-dc added pr/not-ready not ready for merging release/none no release note do-not-merge/waiting labels Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3aaa45a) 81.10% compared to head (dd559ef) 81.05%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
- Coverage   81.10%   81.05%   -0.06%     
==========================================
  Files          49       49              
  Lines        5336     5336              
==========================================
- Hits         4328     4325       -3     
- Misses        852      854       +2     
- Partials      156      157       +1     
Flag Coverage Δ
unittests 81.05% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ty-dc ty-dc force-pushed the e2e/spidercoordinator branch from 9e12e4b to de55071 Compare December 18, 2023 02:36
@ty-dc ty-dc requested a review from Icarus9913 as a code owner December 18, 2023 02:36
@ty-dc ty-dc force-pushed the e2e/spidercoordinator branch 5 times, most recently from f5e2e6b to e7f786f Compare December 19, 2023 10:15
@ty-dc
Copy link
Collaborator Author

ty-dc commented Dec 19, 2023

#2928 has been fixed and the PR has been rebase main

@ty-dc ty-dc force-pushed the e2e/spidercoordinator branch 2 times, most recently from 25336a3 to a65bee9 Compare December 19, 2023 10:37
@ty-dc ty-dc added kind/test and removed pr/not-ready not ready for merging do-not-merge/waiting labels Dec 19, 2023
@weizhoublue
Copy link
Collaborator

CI ?

@ty-dc ty-dc force-pushed the e2e/spidercoordinator branch 2 times, most recently from ec499a2 to 11d296e Compare December 20, 2023 02:43
@ty-dc ty-dc force-pushed the e2e/spidercoordinator branch from 11d296e to dd559ef Compare December 20, 2023 06:10
@weizhoublue weizhoublue merged commit f6f1f4f into spidernet-io:main Dec 22, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants