Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidercoordinator: It should update the status to NotReady if any errors occur #2929

Merged

Conversation

cyclinder
Copy link
Collaborator

@cyclinder cyclinder commented Dec 15, 2023

Thanks for contributing!

What type of PR is this?

  • release/none

What this PR does / why we need it:

If obtaining the CIDR information of the cluster fails, we should update its status to NotReady. This prevents the normal creation of pods. Otherwise, the pod will use the incorrect CIDR. Causing communication issues.

Which issue(s) this PR fixes:

Fixes #2928

Special notes for your reviewer:

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #2929 (b6bbd2c) into main (b9e6d82) will not change coverage.
Report is 16 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2929   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          49       49           
  Lines        5333     5333           
=======================================
  Hits         4325     4325           
  Misses        852      852           
  Partials      156      156           
Flag Coverage Δ
unittests 81.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@weizhoublue
Copy link
Collaborator

I suggest that the PR title could be changed to explain the influence for the user.
That would make more sense in the release note

@cyclinder cyclinder changed the title spidercoordinator: Fix don't update status if error return spidercoordinator: It should update the status to NotReady if any errors occur Dec 18, 2023
@weizhoublue weizhoublue merged commit dccff40 into spidernet-io:main Dec 18, 2023
42 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
spidercoordinator: It should update the status to NotReady if any errors occur
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
spidercoordinator: It should update the status to NotReady if any errors occur
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State synchronization of spidercoodinator failed.
2 participants