Add cluster dropdown menu for grafana dashboard #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lou-lan
force-pushed
the
dropdown-menu
branch
2 times, most recently
from
5761e4e to
7a2dd4e
Compare
weizhoublue
reviewed
Dec 18, 2024
| @@ -97,7 +97,7 @@ | |||
| "uid": "${datasource}" | |||
| }, | |||
| "editorMode": "code", | |||
| "expr": "count(count(rdma_tx_vport_rdma_unicast_bytes_total{pod_name!=\"\"}) by (node_name))", | |||
| "expr": "count(count(rdma_tx_vport_rdma_unicast_bytes_total{pod_name!=\"\",cluster=~\"$cluster\"}) by (node_name))", | |||
There was a problem hiding this comment.
Possibly it could add a new helm value , which could help turn on or off the cluster label . the off case is used for open-source case
There was a problem hiding this comment.
This will be better, but in charts/spiderpool/files/*does not support helm value (grafana dashboard json conflicted to helm vlaues, so we move it to this path).
Othewise, we need decouple grafana dashboard file, then import different file (multi cluster and classic ) in the fellow file. such we have 5*2 grafana dashboard file.
Signed-off-by: lou-lan <[email protected]>
lou-lan
force-pushed
the
dropdown-menu
branch
from
f48a184 to
c09e9cb
Compare
weizhoublue
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #
Special notes for your reviewer:
The
clusterlabel is a general multi-cluster label. If a metric includes this label, it allows for the selection of different clusters. The dropdown menu will not be affected even if the user's collector is single-cluster.case single cluster
case multi cluster
