Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: FIx fail to upload multiple artifacts with the same name #4439

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

cyclinder
Copy link
Collaborator

@cyclinder cyclinder commented Dec 25, 2024

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

As the following part of #4437

Fixes https://github.com/spidernet-io/spiderpool/actions/runs/12491914214/job/34858519869?pr=4393

Ref to: actions/upload-artifact#480

@cyclinder cyclinder added release/none no release note cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. labels Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.47%. Comparing base (abf8405) to head (28236cd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4439      +/-   ##
==========================================
- Coverage   79.85%   79.47%   -0.38%     
==========================================
  Files          54       54              
  Lines        6388     6388              
==========================================
- Hits         5101     5077      -24     
- Misses       1086     1115      +29     
+ Partials      201      196       -5     
Flag Coverage Δ
unittests 79.47% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@weizhoublue weizhoublue merged commit 3b185f0 into spidernet-io:main Dec 25, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. release/none no release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants