Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the pod fails to run because the certificate of the pod webhook is not up to data after helm upgrade #4451

Merged

Conversation

cyclinder
Copy link
Collaborator

@cyclinder cyclinder commented Dec 29, 2024

Using helm templates to rendering podwebhook config rather than controller genarated, which can advoid the webhook cert would be revert when helm upgrade, it can leads to pod fail to start.

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4449

Special notes for your reviewer:

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.12%. Comparing base (c50fe51) to head (83bb4b3).
Report is 2 commits behind head on release-v1.0.

Files with missing lines Patch % Lines
pkg/podmanager/pod_webhook.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #4451      +/-   ##
================================================
- Coverage         79.36%   79.12%   -0.24%     
================================================
  Files                51       51              
  Lines              5802     5697     -105     
================================================
- Hits               4605     4508      -97     
+ Misses             1032     1025       -7     
+ Partials            165      164       -1     
Flag Coverage Δ
unittests 79.12% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/podmanager/utils.go 45.20% <ø> (-21.06%) ⬇️
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)

Using helm templates to rendering podwebhook config rather than controller genarated, which can advoid the webhook cert would be revert when helm upgrade, it can leads to pod fail to start.

Signed-off-by: Cyclinder Kuo <[email protected]>
@cyclinder cyclinder force-pushed the 1.0_cp/fix_cert_upgrade branch from 5c267c5 to 83bb4b3 Compare December 30, 2024 02:11
@weizhoublue weizhoublue merged commit dfc289e into spidernet-io:release-v1.0 Dec 30, 2024
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to cherry pick PR 4420 from cyclinder, to branch release-v1.0
2 participants