Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting IP conflicts takes place before gateway detection, avoiding communication failure #4507

Conversation

cyclinder
Copy link
Collaborator

Detect IP conflicts before gateway detection to fix gateway detection could potentially update the arp table causing communication fail

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4484

Special notes for your reviewer:

… could potentially update the arp table causing communication fail

Signed-off-by: Cyclinder Kuo <[email protected]>
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.35%. Comparing base (ffcff3b) to head (dbd5ab0).
Report is 2 commits behind head on release-v1.0.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           release-v1.0   #4507   +/-   ##
============================================
  Coverage          1.35%   1.35%           
============================================
  Files                56      56           
  Lines              6591    6591           
============================================
  Hits                 89      89           
  Misses             6492    6492           
  Partials             10      10           
Flag Coverage Δ
unittests 1.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@weizhoublue weizhoublue changed the title Detect IP conflicts before gateway detection to fix communication fail Detecting IP conflicts takes place before gateway detection, avoiding communication failure Jan 3, 2025
@weizhoublue weizhoublue merged commit 067e7cd into spidernet-io:release-v1.0 Jan 3, 2025
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to cherry pick PR 4474 from cyclinder, to branch release-v1.0
2 participants